borco / plantumlqeditor

A PlantUML editor written in Qt
https://sourceforge.net/projects/plantumlqeditor/
50 stars 9 forks source link

Missing appdata and screenshots for AppStream #8

Closed dwrobel closed 7 years ago

dwrobel commented 7 years ago

Hi,

I'd like to package the plantumlqeditor software for Fedora. The packaging is completed now in ~95% and available in the copr repository. The last missing point is a lack of appdata file, and more precisely screenshots with required resolution. According to 4.1.3. Recommended metadata file contents:

All screenshots should have a 16:9 aspect ratio, and should have a width that is no smaller than 620px Screenshots should be in PNG or JPEG format. PNG is the preferred format;

I would appreciate if you can create one to three screenshots of plantumlqeditor as that would allow the software to appear in the Software Centers (e.g. GNOME).

A ready to use example of appdata file can be taken here the thing which needs to be adjusted are links to new screenshots which now points to SF page which have images with too small width and height:

$ appstream-util validate-relax plantumlqeditor.appdata.xml 
plantumlqeditor.appdata.xml: FAILED:
• attribute-invalid     : <screenshot> width too small [https://a.fsdn.com/con/app/proj/plantumlqeditor/screenshots/mainwindow.png/182/137/1]
• attribute-invalid     : <screenshot> height too small [https://a.fsdn.com/con/app/proj/plantumlqeditor/screenshots/mainwindow.png/182/137/1]
• attribute-invalid     : <screenshot> width too small [https://a.fsdn.com/con/app/proj/plantumlqeditor/screenshots/mainwindow--sequence-assistant.png/182/137/1]
• attribute-invalid     : <screenshot> height too small [https://a.fsdn.com/con/app/proj/plantumlqeditor/screenshots/mainwindow--sequence-assistant.png/182/137/1]
• attribute-invalid     : <screenshot> width too small [https://a.fsdn.com/con/app/proj/plantumlqeditor/screenshots/propertiesdialog.png/182/137/1]
• attribute-invalid     : <screenshot> height too small [https://a.fsdn.com/con/app/proj/plantumlqeditor/screenshots/propertiesdialog.png/182/137/1]
Validation of files failed

Once the correct images will be used then the validation process should pass without failures.

ghost commented 7 years ago

Hi,

The original images are stored in docs:

https://github.com/borco/plantumlqeditor/blob/master/docs/mainwindow--sequence-assistant.png https://github.com/borco/plantumlqeditor/blob/master/docs/mainwindow.png https://github.com/borco/plantumlqeditor/blob/master/docs/propertiesdialog.png

From what I see, they should be large enough. Please let me know if you need something else.

Cheers.

ghost commented 7 years ago

I've updated those images with newer versions.

dwrobel commented 7 years ago

Please let me know if you need something else.

Thank you for a prompt reply, this solved the issue, please find PR #9 with updated appdata.

ghost commented 7 years ago

appdata merged