search

bordaigorl / remy

Remy, an online&offline manager for the reMarkable tablet
GNU General Public License v3.0
285 stars 13 forks source link

Restart the current launcher when it is not `xochitl` #50

Open mathias-sm opened 1 year ago

mathias-sm commented 1 year ago

Thanks for this amazingly useful tool!

On my device, after each use of remy the UI was all messed up until the next reboot. This quote from the readme put me on the right track:

If Remy crashes and the remarkable seems unresponsive it is only because Remy re-enables the main UI of the tabled on exit; to regain control of the tablet you have three options: try and run Remy again and close it cleanly; or run ssh REMARKABLEHOST /bin/systemctl start xochitl; or manually reboot the device. Don't worry nothing bad is happening to the tablet in this circumstance.

As far as I can tell by xochitl is hardcoded, see here and here, maybe other places. However on my device I use remux and so restarting xochitl lead to a visual mess (I'm surprised it even works!)

As a quick fix, I hardcoded remux in remy/remarkable/filesource.py: so far it seems to work, but I imagine it would be worth either making it a configurable string in config.json, or executing systemctl on the device to know which launcher is running and restart that one.

Happy to try and draft a PR with either solution if you think it's worth it!

iHnR commented 1 year ago

I've also been having this problem. It seems like there's somehow two instances of xochitl running at the same time? A config of inference option would be really nice.

data-flux commented 1 year ago

A more elegant solution than a config might be to use systemctl is-active with a list of launchers to check, remux, tarnish, draft, xochitl, and restarting the one that is actually running.

For now, I'm going to hardcode tarnish, but I'd love to see this feature, it is a major annoyance with what is otherwise the best gui interface for remarkable.

data-flux commented 1 year ago

Created a pull request

bordaigorl commented 1 year ago

Ah @data-flux thanks! I actually implemented this (using your suggestion about systemctl is-active) just haven't pushed it yet as I needed to add docs... Should appear in devel by end of today

data-flux commented 1 year ago

Cheers!

I actually decided to use is-enabled, because is-active will fail if the user enables the banner function, I think.

bordaigorl commented 1 year ago

@data-flux could you test #57 ? It should work fine with the banner function too.