search

bordaigorl / rmview

A live viewer for reMarkable written in PyQt5
GNU General Public License v3.0
742 stars 61 forks source link

Fix connecting with new paramiko version #128

Closed bennofs closed 2 years ago

bennofs commented 2 years ago

Connecting to remarkable with 2.9 fails without this fix

gustaphe commented 2 years ago

Great timing! My problem in #127 disappeared when I downgraded paramiko to 2.8.1. I don't know if this PR works, but at least it correctly fingered paramiko 2.9 as the culprit.

bordaigorl commented 2 years ago

Thank you so much @bennofs it would have taken me ages to debug related issues! @gustaphe it would be great if you could test this branch (you can checkout the code and pip install again)

gustaphe commented 2 years ago

I don't know python, so I'm uncertain if I'm testing the right thing, but

pip install --upgrade paramiko
pip install .
rmview -v

from inside this directory worked perfectly so I guess that's an LGTM from me.