search

bordaigorl / rmview

A live viewer for reMarkable written in PyQt5
GNU General Public License v3.0
742 stars 61 forks source link

Add dockerfile and run script #71

Closed larsblumberg closed 3 years ago

larsblumberg commented 3 years ago

This MR introduces a Dockerfile and a run script to facilitate running rmview in a Docker container. This is interesting for Docker users as it avoids installing any other requirements (besides Docker) on your host system. The MR adds a section to the README.md file for installing and running rmview with Docker.

bordaigorl commented 3 years ago

Sweet! Thanks so much. The devel branch is where I'm collecting stuff for the new release, maybe it's a good idea to merge there? In that case it would be probably a good idea to use pip install ".[tunnel]"

larsblumberg commented 3 years ago

Ok, I have made the requested changes and tested them. I however didn't test the new tunnel feature, but I'd expect it to work, too, since docker-run.sh runs the Docker container using the host network setting.