do not garbage collect cloned frames and create them with the correct rotation

bordaigorl / rmview

A live viewer for reMarkable written in PyQt5

GNU General Public License v3.0

742 stars 61 forks source link

do not garbage collect cloned frames and create them with the correct rotation #79

Closed vale981 closed 3 years ago

vale981 commented 3 years ago

fixes #61

The problem was that the variable v had no owner after the end of the function which caused the garbage collector to eat it. Also I found that the frames were not created with the correct rotation.

bordaigorl commented 3 years ago

Oh my god of course!!!! The "double" memory management of PyQt is the major headache with an otherwise completely excellent UI framework!

bordaigorl commented 3 years ago

Added garbage collection on close. This way we don't leak memory if one opens and closes many clones.