search

bordoni / fakerpress

A WordPress plugin that implements an easy way to create fake data inside WordPress.
http://fakerpress.com
Other
338 stars 54 forks source link

call_user_func_array calls need more array_values updates #171

Open sc0ttkclark opened 1 year ago

sc0ttkclark commented 1 year ago

There are still some stragglers that use call_user_func_array and pass in arrays that have string keys. Those get interpreted as PHP named arguments just like what was reported at https://github.com/bordoni/fakerpress/issues/147

That one case was fixed but there are likely others, especially ones in this kind of context with min/max or width/height.

This may take manual review on your side to ensure that they are caught as I don't want to just PR the changes with array_values() everywhere it may not be needed.

bordoni commented 1 year ago

Thank you @sc0ttkclark I finally should have some extra time this upcoming week, I will definitely make sure this is included.