boredazfcuk / docker-icloudpd

An Alpine Linux container for the iCloud Photos Downloader command line utility
1.57k stars 149 forks source link

Debug logging partially persists when set to false #543

Closed undaunt closed 1 month ago

undaunt commented 2 months ago

Hello,

I've seen debug logs specifically for file already exists and file deduplicated even with debug logging disabled in the configuration. When I turned on debug to troubleshoot webhook notifications, I did note more debug logs, so I'm wondering why the file messages continue to show when debug logging is turned off.

Sample:

2024-04-12T19:53:23.138410838Z 2024-04-12 12:53:23 DEBUG    /photos/PrimarySync/2024/01-2024/01-14-2024/lp_image-254411.heic deduplicated
2024-04-12T19:53:23.138442354Z 2024-04-12 12:53:23 DEBUG    /photos/PrimarySync/2024/01-2024/01-14-2024/lp_image-254411.heic already exists
2024-04-12T19:53:23.138474979Z 2024-04-12 12:53:23 DEBUG    /photos/PrimarySync/2024/01-2024/01-14-2024/lp_image_HEVC-609676.MOV deduplicated
2024-04-12T19:53:23.138505979Z 2024-04-12 12:53:23 DEBUG    /photos/PrimarySync/2024/01-2024/01-14-2024/lp_image_HEVC-609676.MOV already exists
2024-04-12T19:53:23.140496212Z 2024-04-12 12:53:23 DEBUG    /photos/PrimarySync/2024/01-2024/01-13-2024/IMG_2955.mov already exists
2024-04-12T19:53:23.140593040Z 2024-04-12 12:53:23 INFO     Found 50 consecutive previously downloaded photos. Exiting
2024-04-12T19:53:23.140617976Z 2024-04-12 12:53:23 INFO     All photos have been downloaded
2024-04-12T19:53:23.140642894Z 2024-04-12 12:53:23 INFO     Deleting any files found in 'Recently Deleted'...
2024-04-12T19:53:24.826576459Z 2024-04-12 12:53:24 DEBUG    Deleting /photos/PrimarySync/2024/03-2024/03-13-2024/lp_image.heic...
2024-04-12T19:53:24.828805010Z 2024-04-12 12:53:24 INFO     Deleted /photos/PrimarySync/2024/03-2024/03-13-2024/lp_image.heic

Thanks very much! Config below:

agentid=
albums_with_dates=false
apple_id=undaunt@contoso.com
auth_china=false
authentication_type=MFA
auto_delete=true
bark_device_key=
bark_server=
content_source_url=
convert_heic_to_jpeg=false
debug_logging=false
delete_accompanying=false
delete_after_download=false
delete_notifications=true
dingtalk_token=
directory_permissions=755
discord_id=
discord_token=
download_notifications=true
download_path=/photos
file_permissions=644
folder_structure={:%Y/%m-%Y/%m-%d-%Y}
force_gid=true
gotify_app_token=
gotify_https=
gotify_server_url=
group=
group_id=1000
icloud_china=
iyuu_token=
jpeg_path=
jpeg_quality=90
libraries_with_dates=true
media_id_delete=
media_id_download=
media_id_expiration=
media_id_startup=
media_id_warning=
nextcloud_delete=false
nextcloud_password=
nextcloud_upload=false
nextcloud_url=
nextcloud_username=
notification_days=7
notification_title=undaunt
notification_type=Webhook
photo_album=
photo_library="all libraries"
photo_size=original
prowl_api_key=
pushover_sound=
pushover_token=
pushover_user=
recent_only=
set_exif_datetime=false
single_pass=false
skip_album=
skip_check=true
skip_download=false
skip_library=
skip_live_photos=false
skip_videos=false
startup_notification=true
synchronisation_delay=0
synchronisation_interval=86400
synology_ignore_path=false
telegram_chat_id=
telegram_polling=true
telegram_server=
telegram_silent_file_notifications=
telegram_token=
touser=
trigger_nextlcoudcli_synchronisation=
until_found=50
user=
user_id=1000
webhook_body=body
webhook_https=false
webhook_id=xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
webhook_path=/notify/
webhook_port=8000
webhook_server=apprise
wecom_id=
wecom_proxy=
wecom_secret=
boredazfcuk commented 2 months ago

These logs:

2024-04-12T19:53:23.138410838Z 2024-04-12 12:53:23 DEBUG    /photos/PrimarySync/2024/01-2024/01-14-2024/lp_image-254411.heic deduplicated
2024-04-12T19:53:23.138442354Z 2024-04-12 12:53:23 DEBUG    /photos/PrimarySync/2024/01-2024/01-14-2024/lp_image-254411.heic already exists
2024-04-12T19:53:23.138474979Z 2024-04-12 12:53:23 DEBUG    /photos/PrimarySync/2024/01-2024/01-14-2024/lp_image_HEVC-609676.MOV deduplicated
2024-04-12T19:53:23.138505979Z 2024-04-12 12:53:23 DEBUG    /photos/PrimarySync/2024/01-2024/01-14-2024/lp_image_HEVC-609676.MOV already exists
2024-04-12T19:53:23.140496212Z 2024-04-12 12:53:23 DEBUG    /photos/PrimarySync/2024/01-2024/01-13-2

Are from a different application, which defaults to debug logging, and the last time I checked, the parameter to control it's log output didn't work.

boredazfcuk commented 1 month ago

I revisited this and the upstream application fixed their logging issue. Having debug_logging set to false should now hide these.

undaunt commented 1 month ago

Oh awesome. was it from pyicloud or icloud-photos-downloader upstream? Thanks!

boredazfcuk commented 1 month ago

iCloud Photos downloader: https://github.com/icloud-photos-downloader/icloud_photos_downloader/pull/664