boredazfcuk / docker-icloudpd

An Alpine Linux container for the iCloud Photos Downloader command line utility
1.57k stars 149 forks source link

Error: Invalid value for '--keep-unicode-in-filenames': '--live-photo-mov-filename-policy' is not a valid boolean. #586

Open myzonexx opened 1 week ago

myzonexx commented 1 week ago

after update to latest version, I restart the container to sync again and it shows the following error Error: Invalid value for '--keep-unicode-in-filenames': '--live-photo-mov-filename-policy' is not a valid boolean. I also tried to add this 2 value into configuration files but it didn't work. anyone knows how to fix it?

yieldhog commented 1 week ago

I'm having the same issue, files are no longer downloading

boredazfcuk commented 1 week ago

What does your configuration file say for those two options?

--keep-unicode-in-filenames should be either true or false... It seems its set to '--live-photo-mov-filename-policy' instead.

yieldhog commented 1 week ago

I upgraded container from a prior version, there are no entries in the icloudpd.conf file for me related to these options

meserwinowski commented 6 days ago

+1 to this issue, same symptoms, just updated docker image and running to this on container start. image

imagesafari commented 6 days ago

Also just pulled a new image and am getting this same error. +1

JuliusB1601 commented 6 days ago

I had the same error. After adding these two to the config with the defaults mentioned in the Configuration.md, everything works fine.

boredazfcuk commented 6 days ago

The script adds the defaults for these settings at launch if it doesn't find them in the icloudpd.conf file already. If they are not there, then there's likely a permissions issue writing to the file.

imagesafari commented 5 days ago

I don't think there was a permissions issue, but I re-created the container and it created a new config file with the proper entries.

Seems like it doesn't handle well just pulling a new image w/the config on a volume that doesn't get updated on launch.

boredazfcuk commented 5 days ago

I run four separate containers, and have added around a dozen options to the config file, since the initial code to create it. I've never seen it fail in testing so in the region of 50ish successful tests.

myzonexx commented 5 days ago

I had the same error. After adding these two to the config with the defaults mentioned in the Configuration.md, everything works fine.

This is a correct suggestion. I tried to add those missing config and fill in the default values, it works fine. Previously I thought I just remain blank after =, it will use default value but actually not.

boredazfcuk commented 5 days ago

This is a correct suggestion. I tried to add those missing config and fill in the default values, it works fine. Previously I thought I just remain blank after =, it will use default value but actually not.

It does not fix the root cause. As further options are added to the icloupd.conf file, these will also fail to be added to the config file.

yieldhog commented 4 days ago

Perhaps I'm missing something here, but, I've pulled down a new image and the new options do not show up in the conf file. There are no permission issues, do I need to delete the container and rebuild from scratch?

boredazfcuk commented 1 day ago

This is a correct suggestion. I tried to add those missing config and fill in the default values, it works fine. Previously I thought I just remain blank after =, it will use default value but actually not.

I've pushed a new version which may resolve this. The script now checks a bunch of variables, and sets a default value for them, if it finds that they are blank.

The script should have added the variables and set their default value. I'm not sure how yours managed to create the setting, but not populate it with the default value. Anyway, that should be fixed in the latest version.