search

boredazfcuk / docker-icloudpd

An Alpine Linux container for the iCloud Photos Downloader command line utility
1.58k stars 149 forks source link

Folder_structure option ignored when specifying photo_library option #594

Closed stingray75 closed 5 days ago

stingray75 commented 5 days ago

I've been using iCloudPD to download my photos from my personal library into YYYY/MM folders for many years - thanks so much for your work on this. I've just started using a shared library with my wife, so I have been moving some of my media from my personal library into the shared library.

In iCloudPD I set the _photolibrary option to "all libraries".

This successfully downloads from both libraries, however, it's now ignoring the _folderstructure option, resulting all personal photos/videos being downloaded into a single folder PrimarySync and shared media into a single folder SharedSync - it's not creating the YYYY/MM folders beneath. This is a problem with 75k photos as some file names are the same.

I can understand that the _photoalbum option doesn't create subfolders, as it's likely that albums will only contain a small amount of photos, but I don't get why the _photolibrary option does this.

It's also creating duplicates, as media I've moved from personal to shared is now downloading from shared but not being removed from my already downloaded personal folder. I'll raise this as a separate issue.

stingray75 commented 5 days ago

Looking through the code, I just found the _libraries_withdates option! It would be useful if you could reference this option under the readme photo_library section. :-)