search

boredzo / iso-8601-date-formatter

A Cocoa NSFormatter subclass to convert dates to and from ISO-8601-formatted strings. Supports calendar, week, and ordinal formats.
http://boredzo.org/iso8601dateformatter/
Other
600 stars 140 forks source link

Rename deprecated API for iOS 8 #46

Closed kostiakoval closed 9 years ago

3lvis commented 9 years ago

Damn, doesn't seem like the guy is supporting his pod. I'll do some magic :D

kostiakoval commented 9 years ago

We can keep supporting it and make it better in our fork :)

3lvis commented 9 years ago

That was my exact thought!

3lvis commented 9 years ago

Do you know if it solves the performance issues of NSDateFormatter?

http://blog.soff.es/how-to-drastically-improve-your-app-with-an-afternoon-and-instruments/

kostiakoval commented 9 years ago

I think yes, but I have't measured it.

zygoat commented 9 years ago

Hey guys. Can you point me to your fork? Is it in CocoaPods? I've recently begun using this one, but realized shortly that building under iOS 8.0 results in lots of deprecation spew, and sadly clued in that this appears to be abandoned. Is there a maintained replacement?

3lvis commented 9 years ago

@zygoat You can use 

pod 'HYP8601'

https://github.com/hyperoslo/HYP8601

boredzo commented 9 years ago

I fixed the performance problems a long time ago. And this isn't abandoned; I merged in a fix just recently. (I will admit I don't always look at my email often enough. ☺)

I want to get more test coverage before I accept larger changes, though.

3lvis commented 9 years ago

@boredzo This isn't about performance, I think iso-8601-date-formatter doesn't have problems in that area. It's about deprecations and Xcode warnings under iOS 8. :)

boredzo commented 9 years ago

I've been going through the PRs one at a time today. I merged #42 earlier, which covers the same territory as this one. Thanks, though!