search

boredzo / iso-8601-date-formatter

A Cocoa NSFormatter subclass to convert dates to and from ISO-8601-formatted strings. Supports calendar, week, and ordinal formats.
http://boredzo.org/iso8601dateformatter/
Other
600 stars 140 forks source link

Add tvOS targets #59

Closed neonichu closed 8 years ago

neonichu commented 8 years ago

This adds a framework target and test target for tvOS.

neonichu commented 8 years ago

If this gets merged, it would be great if there could also be a new point release and an update of the podspec on trunk to add tvOS support :ok_hand:

boredzo commented 8 years ago

Is there an advantage to having a separate target, vs adding AppleTV as a supported platform to the existing target?

victor commented 8 years ago

I needed this library for an AppleTV project, all I needed to do was add tvOS as a deployment target to my local copy of the podspec. I'd appreciate it if the project adopted an official podspec in the repo itself, and with tvOS support if possible, so as to have a simpler Podfile.

neonichu commented 8 years ago

@boredzo probably not, I didn't know that was possible

neonichu commented 8 years ago

I updated the PR so that it adds tvOS support to the existing CocoaTouch targets — much cleaner, thanks for the suggestion :+1:

boredzo commented 8 years ago

Thanks for getting this done!

neonichu commented 8 years ago

Thanks for merging! Would be great if you could also push a new release to CocoaPods trunk at some point with the additional platform support.

iGranDav commented 8 years ago

Hi, just want to up this subject to push the tvOS compatible version to CocoaPods trunk please.