search

borela / naomi

Sublime Text enhanced syntax highlighting for JavaScript ES6/ES7/ES2015/ES2016/ES2017+, Babel, FlowType, React JSX, Styled Components, HTML5, SCSS3, PHP 7, phpDoc, PHPUnit, MQL4. Basic: Git config files.
Other
558 stars 18 forks source link

[JS] Line comment stops too early #177

Closed StreetStrider closed 5 years ago

StreetStrider commented 5 years ago

Hello. After a couple of releases it seemes that line comment scope breaks to early. I noticed it because I'm using distinctive background for comment.

line comment

Expected behavior: comment background should span whole line, because it is a line comment.

borela commented 5 years ago

This is probably caused by this line https://github.com/borela/naomi/blob/master/syntaxes/fjsx15/comment/line.sublime-syntax#L34 can you change it to - match: \n and see if works? If it does, please send a pull request and I'll merge on all branches.

StreetStrider commented 5 years ago

@borela, okay, will do. Will modifying local files prevent Package Control from taking from upstream?

borela commented 5 years ago

In theory no unless a git conflict arises, you'll see package control show an error when it can't pull the origin's changes.