borevitzlab / TraitCapture-R-Code

0 stars 0 forks source link

In /graphs/ folder output all area graphs, one each for each accession #6

Open TimeScience opened 8 years ago

TimeScience commented 8 years ago

For the area by time plots, in addition to the current output methods, please add outputting every individual graph as a jpg. This will be used in the future for loading growth curve graphs to the website

Thanks

For now put them in the folder: /graphs/areaplots/ filename: EXPID-PlantID-area.jpg example: BVZ0051-84569-area.jpg

rcheng commented 8 years ago

JPG files have been created for each plant (if possible) and placed in folder "images". However, three of the four 'area' data files for BVZ0036 do NOT conform to your standard format which uses the first two lines for header information. The same problem exists for BVZ0043. Please let me know when this is corrected.

TimeScience commented 8 years ago

three of the four 'area' data files for BVZ0036 do NOT conform to your standard format which uses the first two lines for header information.

Can you send file names and I'll look into it? I will then file an issue on github with sara (snamin) and it will be her job to fix it. As we move forward you can file issues as well and assign them to people so they know it is their job to fix it :)

TimeScience commented 8 years ago

This looks great. Thanks!

Small issue: Can you change the naming format to be "-plantID" rather than "plantID" currently the "" is a reserved character for separating filenames from the timestamp in the name.

Thanks

rcheng commented 8 years ago

All but the first of "BVZ0036-GC02L-C01-area.csv", "BVZ0036-GC02R-C01-area.csv", "BVZ0036-GC05L-C01-area.csv" and "BVZ0036-GC05R-C01-area.csv". This problem should exist in other data files in the same folders.