borevitzlab / timestreamlib

DEPRECATED. Please use the current version of the TimeStream tools at https://gitlab.com/appf-anu/pyts2.
https://gitlab.com/appf-anu/pyts2
GNU General Public License v3.0
7 stars 4 forks source link

Miscellaneous commits to add to next #138

Closed Joelgranados closed 9 years ago

Joelgranados commented 9 years ago

Misc commits to add to next

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-8.17%) when pulling 18f7c839cf841bc15a232b6113b09fcccd8ffb89 on Joelgranados:devel into 71f3de7b98f69bbc40b2656ae5337b2598be93c5 on borevitzlab:next.

kdm9 commented 9 years ago

Looks great man, see diff comments above.

kdm9 commented 9 years ago

Note I haven't reviewed the GUI stuff, as I have no idea what I'm talking about, so I'll leave it to you.

Joelgranados commented 9 years ago

Kevin:

I addressed changed the PR based on your comment. Is it ok if we pull it in.

Would I be able to do a rebase against borevitz/next and push it to borevitz myself. I still prefer rebase than merge in these cases. Tell me what you think

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-8.17%) when pulling 83a2e4c91b8ce1054f09e3dd664382bfb86de60f on Joelgranados:devel into 71f3de7b98f69bbc40b2656ae5337b2598be93c5 on borevitzlab:next.

kdm9 commented 9 years ago

:+1: Merging