borevitzlab / timestreamlib

DEPRECATED. Please use the current version of the TimeStream tools at https://gitlab.com/appf-anu/pyts2.
https://gitlab.com/appf-anu/pyts2
GNU General Public License v3.0
7 stars 4 forks source link

[WIP] Inline image resize-on-writer #149

Closed kdm9 closed 9 years ago

kdm9 commented 9 years ago

This adds to ResultingImageWriter the ability to resize images before writing. This is probably broken (I'm still working on the test server, so I've not tested it), and this implementation doesn't support more than one size, or handle stream names well.

Dont merge till it's done.

K

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-0.13%) when pulling d7afd18835731fe004054b4b17fb581913a421d2 on kdmurray91:feat/imagewriter-resize into 6adeb642b485687d53316873bdd6d3cdfe13369a on borevitzlab:next.

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-0.13%) when pulling d7afd18835731fe004054b4b17fb581913a421d2 on kdmurray91:feat/imagewriter-resize into 6adeb642b485687d53316873bdd6d3cdfe13369a on borevitzlab:next.

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-0.13%) when pulling d7afd18835731fe004054b4b17fb581913a421d2 on kdmurray91:feat/imagewriter-resize into 6adeb642b485687d53316873bdd6d3cdfe13369a on borevitzlab:next.

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-0.13%) when pulling b45febe220758f0b8ec6fd459f36234ab576e7a9 on kdmurray91:feat/imagewriter-resize into 6adeb642b485687d53316873bdd6d3cdfe13369a on borevitzlab:next.

coveralls commented 9 years ago

Coverage Status

Changes Unknown when pulling d2f4c7f55428556f854e1a55f1ba2b61d6e9dd4e on kdmurray91:feat/imagewriter-resize into \ on borevitzlab:next**.

coveralls commented 9 years ago

Coverage Status

Changes Unknown when pulling 2739cf77df7751f6b75a2bac30a1f05f4ccbd06e on kdmurray91:feat/imagewriter-resize into \ on borevitzlab:next**.

kdm9 commented 9 years ago

Joel,

Please review again, I think all is as you wished.

In future, can you comment on the pull request itself, not the commits, as I rebased onto next and now your comments are gone. There's also a way to comment on the diff, if you want to comment on lines. Then the comments get hidden if the diff changes/gets rebased, but the comments are not lost.

Thanks, K

Joelgranados commented 9 years ago

This looks good. If you have tested it, I would go ahead and merge. If you have not tested it, please test first and then merge.