search

borevitzlab / timestreamlib

DEPRECATED. Please use the current version of the TimeStream tools at https://gitlab.com/appf-anu/pyts2.
https://gitlab.com/appf-anu/pyts2
GNU General Public License v3.0
7 stars 4 forks source link

Pipeline test and Misc fixes #150

Closed Joelgranados closed 9 years ago

Joelgranados commented 9 years ago

Main push is for pipeline test cases. Pretty self explanatory in the commit messages. We still need to address the fact that we can't push to tests/data because its another git repository.

I suggest we put all the stuff in tests/data in this (timestreamlib) repo. The work-flow for pushing a commit that has to do with these two repositories is just crazy: I have to fork the data repo, create a PR, get it reviewed (separately though they are linked), then merge in data. Only when that happens can I really finish the PR in timestreamlib by updating the data submodule pointer. Additionally the reviews (of the same logic) will happen in two different places making it difficult to keep track of what is going on.

coveralls commented 9 years ago

Coverage Status

Coverage increased (+6.78%) when pulling 21f78de69fbeedfedf7b44a7264153470cb083fc on Joelgranados:next into 6adeb642b485687d53316873bdd6d3cdfe13369a on borevitzlab:next.

Joelgranados commented 9 years ago

Notice that the build failure is probably due to the fact that its not finding the data test directory. Lets please put all the test data in timestreamlib so we can avoid this extra step.

Additionally, the failure can also come from the dependencies in the pipeline test. This PR adds testing for the whole pipeline and therefore everything is used: opencv, skimage, numpy, scipy..... If one of these is not correctly installed in the Travis test machine, it will blow up.

kdm9 commented 9 years ago

This looks awesome man!! cheers.

Some small comments, but nothing major.

Joelgranados commented 9 years ago

This PR now has the tests/data update

coveralls commented 9 years ago

Coverage Status

Coverage increased (+6.78%) when pulling 7e735a4e2d556459cabf2f522d7ceb17edcd50cc on Joelgranados:next into 799b9001ffeca6c4ebcdbbcdad7c5b54fdcef515 on borevitzlab:next.

kdm9 commented 9 years ago

One more thing we need: add pyQT4 to the requirements.txt file.

See http://biojenkins.anu.edu.au/job/timestreamlib/default/98/console

kdm9 commented 9 years ago

OK, since Joel's gone, I'm going to merge this to a different branch, and continue the PR there, so I can add commits to fix things.