search

borevitzlab / timestreamlib

DEPRECATED. Please use the current version of the TimeStream tools at https://gitlab.com/appf-anu/pyts2.
https://gitlab.com/appf-anu/pyts2
GNU General Public License v3.0
7 stars 4 forks source link

Add Metaids in TimeStream object #86

Closed Joelgranados closed 9 years ago

Joelgranados commented 10 years ago

Metaids is a way for the user to give the "true" ids of the pots. We read these metaids from the config file into the settings of the TimeStream object. There are several problems with having these metaids in the settings:

1) The relation is soft, there are no checks to see if the list of metaids that the user gave us is sane. 2) Json does not know how to handle string dictionary keys. Metaids depend on this as the pot ids are int. 3) metaids should be an intrinsic part of the TimeStream class. There should be a _metas variable. metas are very important because they not only allow us to derandomize, they are needed to give the statistician the feature values (area, perimeter....) related to the "real" id.

kdm9 commented 10 years ago

Go for it man! sounds like a good idea. Just don't stick it in the v0 branch.

Joelgranados commented 9 years ago

The metaids are already in timestream.data["settings"]["metas"]. Though I would like to have something like _metas in timestream, I think we should leave it like this for now and see how it evolves.

  1. There is still no check and I don't really know how to check for this soft relation.
  2. I solved this by checking int and string in the code.
  3. as I said, its in timestream.data["settings"]["metas"]