search

borgbackup / borg

Deduplicating archiver with compression and authenticated encryption.
https://www.borgbackup.org/
Other
11.23k stars 743 forks source link

check 3rd party xattr lib #113

Open ThomasWaldmann opened 9 years ago

ThomasWaldmann commented 9 years ago

xattr lib: https://github.com/xattr/xattr could / should we use that instead of own xattr code? con: xattr keys must decode as utf-8: https://github.com/xattr/xattr/issues/36 con: race conditions

pyxattr lib: https://github.com/iustin/pyxattr Official support for Linux, but also has code for OS X. Python extension, written in C. con: ?

python stdlib os module https://docs.python.org/3/library/os.html?highlight=xattr#linux-extended-attributes Officially only supports Linux.

anarcat commented 9 years ago

classic case of dependency cost analysis. key quote:

It may be that my own library turns out to be inadequate. Then, and only then, is when I start researching other libraries. Until then, I'll avoid the cost of research to find a suitable library, the cost of learning the chosen one, the cost of integrating it into Obnam, the cost to porters of Obnam of dealing with a new dependency, and the risk of the library changing in ways that are unsuitable for Obnam.

are there problems with our current xattr code? does https://github.com/xattr/xattr fix those?

ThomasWaldmann commented 9 years ago

It is platform dependant code, so it needs to be written and mainained for each platform we support. For me it is rather clear that that work is more effectively shared amonst all developers needing such code if it is done in a "shared" library module than separately in each application.

anarcat commented 9 years ago

On 2015-09-30 16:32:44, TW wrote:

For me it is rather clear that that work is more effectively shared amonst all developers needing such code if it is done in a "shared" library module than separately in each application.

agreed.

ThomasWaldmann commented 6 years ago

https://www.worrbase.com/2015/12/30/extended-attributes.html