borgbackup / borg

Deduplicating archiver with compression and authenticated encryption.
https://www.borgbackup.org/
Other
11.06k stars 739 forks source link

Symlink follows by default #7138

Closed lamyergeier closed 1 year ago

lamyergeier commented 1 year ago

Have you checked borgbackup docs, FAQ, and open Github issues?

Yes

Is this a BUG / ISSUE report or a QUESTION?

Issue

System information. For client/server mode post info for both machines.

Your borg version (borg -V). 1.2.2

Operating system (distribution) and version. Ubuntu 22.04.1

Hardware / network configuration, and filesystems used. Intel 12 Gen, 32 GB RAM, LVM, Ext4

How much data is handled by borg? 500 GB

Full borg commandline that lead to the problem (leave away excludes and passwords)

I use the Vorta GUI. I raised this issue [Symlink follows by default · Issue #1477 · borgbase/vorta](https://github.com/borgbase/vorta/issues/1477), but thes asked me to contact here.

Describe the problem you're observing.

I have added .nobackup:

image

In my Sources there is a folder inside which I have added .nobackup file, and this folder was not in the backup, as expected. At another location in the Sources, I have a symlink to the previous folder which has .nobackup file. The previous folder got added to the backup through the symlinked location!

Please change this default behavior to not to follow the symlink as it can also lead to circular endless loop!

Can you reproduce the problem? If so, describe how. If not, describe troubleshooting steps you took before opening the issue.

See above

Include any warning/errors/backtraces from the system logs

ThomasWaldmann commented 1 year ago

borg does not follow symlinks by default.

ThomasWaldmann commented 1 year ago

So, what's needed here if you still think the issue is valid and reproducible: a way to reproduce it, giving the full borg and other commands needed to do that.

lamyergeier commented 1 year ago

Actually I don't use command line, I am using Vorta. The issue is reproducible with Vorta. Please see the following link:

https://github.com/borgbase/vorta/issues/1477

ThomasWaldmann commented 1 year ago

You can look up the borg command line commands in your vorta log, please do so.