search

borgbackup / borg

Deduplicating archiver with compression and authenticated encryption.
https://www.borgbackup.org/
Other
10.74k stars 734 forks source link

improve acl_get / acl_set error handling (1.4-maint) #8125

Closed ThomasWaldmann closed 3 months ago

ThomasWaldmann commented 4 months ago

This definitely will need some review and practical testing.

Fixes #4049. Fixes #8139.

codecov-commenter commented 4 months ago

Codecov Report

Attention: Patch coverage is 50.00000% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 82.84%. Comparing base (3647426) to head (7ba843b). Report is 16 commits behind head on 1.4-maint.

Files Patch % Lines
src/borg/archive.py 50.00% 4 Missing and 1 partial :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## 1.4-maint #8125 +/- ## ============================================= + Coverage 82.61% 82.84% +0.23% ============================================= Files 38 38 Lines 10973 10981 +8 Branches 2100 2102 +2 ============================================= + Hits 9065 9097 +32 + Misses 1345 1326 -19 + Partials 563 558 -5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ThomasWaldmann commented 3 months ago

OK, looks like nobody wants to review this, so we'll test it as is in next beta...