Typo: trailling period or not trailing period (full stop)?

trendymail commented 4 months ago

Hello!

Have you checked borgbackup docs, FAQ, and open GitHub issues?

No, except https://github.com/borgbackup/borg/pull/7946

Is this a BUG / ISSUE report or a QUESTION?

Typo?

Your borg version (borg -V).

1.2.7

Full borg commandline that lead to the problem (leave away excludes and passwords)

borg info \<nonexistent repo>

Repository \<nonexistent repo> does not exist. <= period

borg info \<existing repo>::\<nonexistent archive>

Archive \<nonexistent archive> does not exist <= no period

I prefer the version without the trailing dot but maybe borg has another choice to standardize error messages.

Have a great day! :)

ThomasWaldmann commented 4 months ago

I tend to add a period if it is a complete sentence, but I guess the messages in the existing code are not completely consistent with that rule.

DarkTechPirate commented 3 months ago

@trendymail @ThomasWaldmann So why this issue is still open , shall i know what need to be modified so that i can start the work ?

ThomasWaldmann commented 3 months ago

This needs a global review of all messages. All phrases that are complete sentences should end with a dot, except if it introduces some sort of listing, then a colon is of course better or some serious warning/error, then a exclamation mark.

I suggest to do that in master branch.

borgbackup / borg