search

borgbackup / borg

Deduplicating archiver with compression and authenticated encryption.
https://www.borgbackup.org/
Other
10.73k stars 734 forks source link

borg 1.4: drop or keep the buster-based binary? #8171

Closed ThomasWaldmann closed 3 weeks ago

ThomasWaldmann commented 3 months ago

The pyinstaller-made fat binaries offered on github releases page are built on debian systems.

They can be usually used on systems with a compatible glibc, thus for compatibility with older systems, an old build system is needed.

But, Debian Buster is running out of LTS support soon: https://wiki.debian.org/LTS

Also, since I removed the bundled xxhash source code from borg 1.4, the build on buster broke, because libxxhash-dev (0.6.5) can not be discovered via pkg-config. This feature has been added later there (0.8 or so) and was initially broken, thus needs 0.8.2 or a fixed package.

So there might be no buster-based borg 1.4 binary (glibc 2.28), unless this is fixed / worked around somehow.

Debian Bullseye offers glibc 2.31, Debian Bookworm offers glibc 2.36.

Considering borg 1.4 is quite similar to borg 1.2, users of older systems can also use the borg 1.2 binaries.

ThomasWaldmann commented 2 months ago

Looks like there is no interest in a buster binary, so we'll drop it.

ThomasWaldmann commented 1 month ago

glibc 2.28 is used by RHEL 8.

ThomasWaldmann commented 1 month ago

About the required xxhash version, from the change log:

upgrade bundled xxhash to 0.7.3, #4891

0.7.2 is the minimum requirement for correct operations on ARMv6 in non-fixup mode, where unaligned memory accesses cause bus errors.

0.7.3 adds some speedups and libxxhash 0.7.3 even has a pkg-config file now.

debian buster

... only has 0.6.5, but for our x86-64 pyinstaller-based fat binary, guess that is good enough.

So, guess the easiest fix for the debian buster box is to use the BORG_LIBXXHASH_PREFIX env var to point to debian's libxxhash.