search

borgbackup / borg

Deduplicating archiver with compression and authenticated encryption.
https://www.borgbackup.org/
Other
10.73k stars 733 forks source link

On Linux test /tmp exec capacity, cythonize needs it #8209

Closed m33m33 closed 1 month ago

m33m33 commented 1 month ago

Proposal for issue #8208

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.24%. Comparing base (caba23f) to head (9c8aede). Report is 18 commits behind head on 1.2-maint.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## 1.2-maint #8209 +/- ## ============================================= - Coverage 82.41% 82.24% -0.17% ============================================= Files 38 38 Lines 10838 10838 Branches 2079 2079 ============================================= - Hits 8932 8914 -18 - Misses 1350 1365 +15 - Partials 556 559 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ThomasWaldmann commented 1 month ago

Thanks for discovering this issue and debugging it!

borg hiding the original exception message was a real bug, based on the wrong assumption that only a missing cython install can trigger that import error.

But I guess I rather won't like to have code like in this PR in setup.py (borg supports misc. Linuxes, misc. BSDs, macOS, misc. OpenSolaris dists and even more or less Windows, so having platform specific code in setup.py catching such issues would really make it much bigger and much more complicated).

So, let's rather try to have a helpful error msg, see #8210.