borgbackup / borg

Deduplicating archiver with compression and authenticated encryption.
https://www.borgbackup.org/
Other
10.73k stars 733 forks source link

setup.py: fix import error reporting for cythonize import, see #8208 #8211

Closed ThomasWaldmann closed 1 month ago

ThomasWaldmann commented 1 month ago

Looks like borg's setup.py has hidden the real cause of a cythonize ImportError.

There are basically 2 cases:

It's important not to hide the real cause, especially if we run into case 2.

case 1 is kind of expected and frequent, case 2 is rare.

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.54%. Comparing base (45038ea) to head (8470730). Report is 1 commits behind head on 1.2-maint.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## 1.2-maint #8211 +/- ## ============================================= - Coverage 82.55% 82.54% -0.01% ============================================= Files 38 38 Lines 10838 10838 Branches 2079 2079 ============================================= - Hits 8947 8946 -1 - Misses 1340 1341 +1 Partials 551 551 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.