search

borgbackup / borg

Deduplicating archiver with compression and authenticated encryption.
https://www.borgbackup.org/
Other
11.24k stars 744 forks source link

docs: Fix grammar in borg mount docs #8510

Closed fantasya-pbem closed 3 weeks ago

fantasya-pbem commented 3 weeks ago

"clean" as adverb does not have suffix -ly.

Source: https://dict.leo.org/grammatik/englisch/adjv_usage_flat.php?lang=de#id=5.3.1.b

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.71%. Comparing base (1ec66ed) to head (d3f3082). Report is 7 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #8510 +/- ## ========================================== + Coverage 81.43% 81.71% +0.28% ========================================== Files 73 73 Lines 13108 13108 Branches 1924 1924 ========================================== + Hits 10674 10711 +37 + Misses 1769 1740 -29 + Partials 665 657 -8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ThomasWaldmann commented 3 weeks ago

Thanks!

jdchristensen commented 3 weeks ago

"cleanly" is correct in this situation, so this should be reverted. For example, there are lots of examples here.

jdchristensen commented 3 weeks ago

The link provided in the original description also gives a similar example: "The hull of the boat cut cleanly through the placid water."

fantasya-pbem commented 3 weeks ago

I did not say that "cleanly" is not a correct adverbial form. But the adjective "clean" does have an adverbial form "clean" that is, in my opinion, the correct adverb here. "Cut cleanly" is not the same clean as in "wipe clean".

jdchristensen commented 2 weeks ago

I agree that "wipe clean" is correct grammar, but it doesn't match the situation in "unmount cleanly". The change in this patch is definitely wrong. Putting it another way, one would never say that we "clean unmount a filesystem". We say that we "cleanly unmount a filesystem", or in other words, that it "unmounts cleanly".

But the original text is slightly awkward, so I would propose: "When running in the foreground, ^C/SIGINT cleanly unmounts the filesystem, but other signals or crashes do not."

(Not that this guarantees anything, but I'm a native speaker.)

fantasya-pbem commented 2 weeks ago

Native speaker wins!

ThomasWaldmann commented 2 weeks ago

Fixed by #8519.