search

borgbackup / homebrew-tap

borgbackup packages for macOS homebrew users
30 stars 7 forks source link

update borg version to 1.1.17 #12

Closed knutov closed 3 years ago

ThomasWaldmann commented 3 years ago

@knutov did you try the formula? there is a new "packaging" depdendency since 1.1.17.

if not, can you try right after I merge?

ThomasWaldmann commented 3 years ago

Our tests have discovered the issue I suspected, so the formula needs updates somehow:

    from packaging.version import parse as parse_version
ModuleNotFoundError: No module named 'packaging'
m3nu commented 3 years ago

Shouldn't be a big change. I can take care of it in a few days. Or @knutov, if he gets there before me.

knutov commented 3 years ago

Well, I tried, but should admit I do not understand how brew works and even how to run formulae from local script :(

brew documentation clearly says:

An arbitrary file: Homebrew can install formulae from a local path. It can point to either a formula file or a bottle. Prefix relative paths with ./ to prevent them from being interpreted as a formula or tap name

but with brew install ./borgbackup-fuse.rb it still wants to full tap name to download from internet

@m3nu please fix this PR if you can.

knutov commented 3 years ago

brew untap borgbackup/tap helped to install from local file.

pip3 install packaging should be added to install script, but I do not understand what code should I write for this.

Everything works if I do it manually before brew install ./homebrew-tap/Formula/borgbackup-fuse.rb

m3nu commented 3 years ago

No worries. I'll wrap it up. Just needs the new dependency added.

m3nu commented 3 years ago

Added the new packaging dependency and checks out now. Anything else you can think of, @knutov ?

ThomasWaldmann commented 3 years ago

@m3nu thanks for fixing the formula.

In the CI logs, there are some strange warnings. Can they be fixed or just ignore them?

m3nu commented 3 years ago

You mean the one below? I always get that when running a formula from a file. Should be fine.

Error: Failed to load cask: borgbackup-fuse.rb
Cask 'borgbackup-fuse' is unreadable: wrong constant name #<Class:0x00007f8eaba7aaf8>
Warning: Treating borgbackup-fuse.rb as a formula.
ThomasWaldmann commented 3 years ago

Yeah, that one. OK, so we ignore it.