borgbase / ansible-role-borgbackup

Ansible role to set up Borg and Borgmatic
MIT License
221 stars 98 forks source link

Create a new release of the role? #109

Closed artybdrlt closed 1 year ago

artybdrlt commented 1 year ago

Hello,

We can no longer use your latest release v.0.9.3 safely because:

You fixed these issues here #107 and there #102 but if we prefer to use your latest release we are stuck.

Thank you

m3nu commented 1 year ago

Hi, Didn't we change the command to borgmatic -C (??) which works everywhere? What else needs changing from here?

artybdrlt commented 1 year ago

Hi, Nothing needs changing. It's just that if we stick to your release v.0.9.3 it will automatically setup borgmatic 1.7.5 which is not compatible with your former cron tasks (borgmatic -c /etc/borgmatic/{{ borgmatic_config_name }} -C -p) so creating a new release would let us the choice to your latest commits.

m3nu commented 1 year ago

Re-running the role should update the cron command, no?

If you just need #107 released, I'll do that right away.

m3nu commented 1 year ago

Just re-checked and borgmatic -C works on all Borgmatic versions:

1.6.6:

    create (--create, -C)
                        Create archives (actually perform backups)

1.7.5

    create (-C)         Create an archive (actually perform a backup)
artybdrlt commented 1 year ago

Sorry if we misunderstood. I'm going to take my latest Borg deployment with your role (release v.0.9.3). I deployed it yesterday. Here is what I've got:

borgmatic --version : 1.7.5

cat /etc/cron.d/borgmatic_config:
35 4 * * * root borgmatic -c /etc/borgmatic/borgmatic_config --create --prune
#Ansible: borgmatic_ynh_cron-check
35 17 18 * * root borgmatic -c /etc/borgmatic/borgmatic_config --check

running borgmatic -c /etc/borgmatic/borgmatic_config --create --prune : 
output:
usage: borgmatic [-h] [-c [CONFIG_PATHS ...]] [--excludes EXCLUDES_FILENAME] [-n] [-nc] [-v {-1,0,1,2}]
                 [--syslog-verbosity {-1,0,1,2}] [--log-file-verbosity {-1,0,1,2}]
                 [--monitoring-verbosity {-1,0,1,2}] [--log-file LOG_FILE]
                 [--override SECTION.OPTION=VALUE [SECTION.OPTION=VALUE ...]] [--no-environment-interpolation]
                 [--bash-completion] [--version]
                 ...
borgmatic: error: unrecognized arguments: --create --prune

In my opinion a new release with #102 and #107 would be nice because I'm stuck atm unless I force borgmatic to be installed with an older version myself.

Thank you

m3nu commented 1 year ago

If you run the role again, it should update the cron task?

I'd like to merge #106 before the next release. Will try to get it out today.

m3nu commented 1 year ago

Done.

https://galaxy.ansible.com/m3nu/ansible_role_borgbackup