borgbase / ansible-role-borgbackup

Ansible role to set up Borg and Borgmatic
MIT License
229 stars 102 forks source link

adjust to new borgmatic checks #119

Closed ramcq closed 1 year ago

ramcq commented 1 year ago

Hey I've been (mis)using the borgmatic_checks variable to set up the new timestamp based checks added in borgmatic 1.6.2. I did this in my vars:

borgmatic_checks:
  - name: repository
    frequency: 1 week
  - name: archives
    frequency: 1 month
borgmatic_large_repo: false

It comes out ugly but totally valid YAML and works fine:

    checks:
        - {'name': 'repository', 'frequency': '1 week'}
        - {'name': 'archives', 'frequency': '1 month'}

I can make a patch to correct the formatting here, but I was wondering if we should do a bit more because IMO we don't need the large repo stuff now that borgmatic can do checks with different frequencies. Am not sure what you think the right approach is, should we just deprecate it and get rid of the differentiated cronjobs/timers, and set the defaults to something like the above, or should we have setting it change the frequency settings to the borgmatic_checks.

conloos commented 1 year ago

Hello @ramcq ,

i thought we removed the variable: "borgmatic_large_repo", maybe you found a remnant. Otherwise that is the example from the Borgmatic Website and Borgmatic should take care of the scheduling.

Greetings Frank

ramcq commented 1 year ago

Yes I had a checkout from a few days ago, this is indeed now fixed!