borgbase / ansible-role-borgbackup

Ansible role to set up Borg and Borgmatic
MIT License
221 stars 98 forks source link

fix borgmatic removal of config-sections #135

Open raph2i opened 1 year ago

raph2i commented 1 year ago

Hey there,

since borgmatic 1.8 the configuration sections "location, storage, etc." are no longer needed. as seen on: https://projects.torsion.org/borgmatic-collective/borgmatic/issues/721

m3nu commented 1 year ago

Hey, thanks for adding this! Since this breaks older borgmatic versions (e.g. if someone installs from a system package) we should probably bump the major version for this.

bmbvenom commented 1 year ago

I started experiencing these warnings a couple of days ago after I upgraded borgmatic and was JUST about to open an issue when I decided to check PRs and see if anyone else had submitted anything for it. Thanks @raph2i very much for submitting the PR. @m3nu is there a timeline for the new major version and when it might hit Ansible Galaxy?

SchizoDuckie commented 11 months ago

There's still a small nitpick for this.

checks:
{% for checks in borgmatic_checks %}
    - name: {{ checks }}
{% endfor %}

But borgmatic is still somehow complaining about the top level sections in the config file with no further details

m3nu commented 11 months ago

Well, if we merge this, it will break for all older versions. That's versus having warnings in newer versions.

SchizoDuckie commented 11 months ago

That's indeed a problem I currently have with my infra. I will try to build upon this to make a version detection and switch the template if i have the time