Open sten0 opened 2 years ago
This line is very dirty. Luckily BorgJob
inherits BackupProfileMixin
without using profile()
. BorgJob
is only a subclass of QObject
although only subclasses of QWidget
have the attribute window()
.
I think the reason for this test fail is a qt bug.
Hi!
Thank you for the quick reply :-)
yfprojects @.***> writes:
This line is very dirty. Luckily
BorgJob
inheritsBackupProfileMixin
without usingprofile()
.BorgJob
is only a subclass ofQObject
although only subclasses ofQWidget
have the attributewindow()
. I think the reason for this test fail is a qt bug.
So there's nothing Vorta can do to mitigate the Qt bug, for example by being less "dirty"?
I've also considered using QT_QPA_PLATFORM=offscreen
rather than
xvfb-run dbus-run-session
, but I suspect it wouldn't support button
click events.
So there's nothing Vorta can do to mitigate the Qt bug, for example by being less "dirty"?
Yes, there is. A little refactoring should do the job.
I've also considered using
QT_QPA_PLATFORM=offscreen
rather thanxvfb-run dbus-run-session
, but I suspect it wouldn't support button click events.
Although some qt internal warnings are displayed all the tests pass.
So there's nothing Vorta can do to mitigate the Qt bug, for example by being less "dirty"?
Yes, there is. A little refactoring should do the job.
Fiouf, that's good news :) Would it be possible to schedule a late October soft deadline for this? That's usually about a month before a big Python release that breaks everything, and I'm hoping that late 2022 early 2023 can be less stressful than this last year.
I've also considered using
QT_QPA_PLATFORM=offscreen
rather thanxvfb-run dbus-run-session
, but I suspect it wouldn't support button click events.Although some qt internal warnings are displayed all the tests pass.
Good to know :) I sounds like xvfb-run is marginally "better" for now though.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Hi,
In the interest of helping to prepare for 0.8.4, I thought I'd mention this flaky test (if you think it's fixed in HEAD, please let me know, and I'll upload to Debian experimental to gain the benefit of early CI). I'm reporting it in case it's something Vorta can and should work around.
https://tests.reproducible-builds.org/debian/rbuild/bookworm/amd64/vorta_0.8.3-1.rbuild.log.gz
Kind regards, Nicholas