search

borgbase / vorta

Desktop Backup Client for Borg Backup
https://vorta.borgbase.com
GNU General Public License v3.0
2k stars 132 forks source link

is_worker_running was fixed, but guess calls might be wrong #1889

Open ThomasWaldmann opened 9 months ago

ThomasWaldmann commented 9 months ago

I recently fixed some unreachable code in that function.

Besides the code being unreachable, the function was also broken and did not work as it was intended. When called with site=None (which is the default) to check if any worker for any site is active, it always returned False before my fix (even if there was some worker running). Now it really checks if there is any worker running.

https://www.reddit.com/r/BorgBackup/comments/1941diz/vorta_091/

I just read there that a user now (since 0.9.1) has problems launching multiple backup tasks in parallel - guess that might be related to wrong calls to that function (which "worked" before I fixed the defect).

github-actions[bot] commented 6 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

ThomasWaldmann commented 6 months ago

stalebot is a rather annoying thing here.

There is no reason for closing an issue just because no one cared for it.

m3nu commented 6 months ago

Agree for some issue, but many older issues are just random and not actionable. Anything with a tag is excluded.