search

borgbase / vorta

Desktop Backup Client for Borg Backup
https://vorta.borgbase.com
GNU General Public License v3.0
2.01k stars 131 forks source link

Window border and shadow missing #1910

Open topas-rec opened 9 months ago

topas-rec commented 9 months ago

Description

I don't see a border or shadow of the vorta window using arch linux. This way it is hard to distinguish vorta from other windows behind it.

Here is a screenshot of some window corners. The one without border is vorta: image

Reproduction

OS

ArchLinux kernel 6.7.0-arch3-1, GNOME Shell 45.3

Version of Vorta

0.9.1

What did you install Vorta with?

Distribution package

Version of Borg

1.2.7

Logs

Jan 26 14:12:24 tobias-pc com.borgbase.Vorta.desktop[4132]: 2024-01-26 14:12:24,144 - vorta.i18n - DEBUG - Loading translation failed for ['en-Latn-GB', 'en-GB'].
Jan 26 14:12:24 tobias-pc com.borgbase.Vorta.desktop[4132]: 2024-01-26 14:12:24,185 - vorta.views.source_tab - DEBUG - Added item number 0 from 1
Jan 26 14:12:24 tobias-pc com.borgbase.Vorta.desktop[4132]: 2024-01-26 14:12:24,336 - vorta.borg.jobs_manager - DEBUG - Add job for site default
Jan 26 14:12:24 tobias-pc com.borgbase.Vorta.desktop[4132]: 2024-01-26 14:12:24,336 - vorta.borg.jobs_manager - DEBUG - Start job on site: default
Jan 26 14:12:24 tobias-pc com.borgbase.Vorta.desktop[4132]: 2024-01-26 14:12:24,340 - vorta.borg.borg_job - INFO - Running command /usr/bin/borg --version
Jan 26 14:12:24 tobias-pc com.borgbase.Vorta.desktop[4132]: 2024-01-26 14:12:24,569 - vorta.borg.jobs_manager - DEBUG - Finish job for site: default
Jan 26 14:12:24 tobias-pc com.borgbase.Vorta.desktop[4132]: 2024-01-26 14:12:24,569 - vorta.scheduler - DEBUG - Refreshing all scheduler timers
Jan 26 14:12:24 tobias-pc com.borgbase.Vorta.desktop[4132]: 2024-01-26 14:12:24,569 - vorta.borg.jobs_manager - DEBUG - No more jobs for site: default
Jan 26 14:12:24 tobias-pc com.borgbase.Vorta.desktop[4132]: 2024-01-26 14:12:24,571 - vorta.scheduler - DEBUG - Scheduler for profile 1 is disabled.
Jan 26 14:12:24 tobias-pc com.borgbase.Vorta.desktop[4132]: 2024-01-26 14:12:24,572 - vorta.scheduler - DEBUG - Scheduler for profile 2 is disabled.
Jan 26 14:12:59 tobias-pc com.borgbase.Vorta.desktop[4132]: 2024-01-26 14:12:59,621 - vorta.keyring.abc - DEBUG - No module named 'objc'
Jan 26 14:12:59 tobias-pc com.borgbase.Vorta.desktop[4132]: 2024-01-26 14:12:59,669 - vorta.keyring.abc - DEBUG - Using VortaSecretStorageKeyring
Jan 26 14:12:59 tobias-pc com.borgbase.Vorta.desktop[4132]: 2024-01-26 14:12:59,669 - vorta.borg.borg_job - DEBUG - Using VortaSecretStorageKeyring keyring to store passwords.
Jan 26 14:12:59 tobias-pc com.borgbase.Vorta.desktop[4132]: 2024-01-26 14:12:59,670 - vorta.keyring.secretstorage - DEBUG - Found 0 passwords matching repo URL.
Jan 26 14:12:59 tobias-pc com.borgbase.Vorta.desktop[4132]: 2024-01-26 14:12:59,670 - vorta.borg.borg_job - DEBUG - Password not found in primary keyring. Falling back to VortaDBKeyring.
Jan 26 14:12:59 tobias-pc com.borgbase.Vorta.desktop[4132]: 2024-01-26 14:12:59,675 - vorta.borg.jobs_manager - DEBUG - Add job for site 1
Jan 26 14:12:59 tobias-pc com.borgbase.Vorta.desktop[4132]: 2024-01-26 14:12:59,675 - vorta.borg.jobs_manager - DEBUG - Start job on site: 1
Jan 26 14:12:59 tobias-pc com.borgbase.Vorta.desktop[4132]: 2024-01-26 14:12:59,694 - vorta.borg.borg_job - INFO - Running command /usr/bin/borg create --list --progress --info --log-json --json --filter=AM -C zstd,8 --exclude-from /tmp/tmpw4plyrew /run/media/tobiasb/DATA BACKUP/BorgBackup::tobias-pc-2024-01-26-141259 /home/tobiasb/DATA
Jan 26 14:13:00 tobias-pc com.borgbase.Vorta.desktop[4132]: 2024-01-26 14:13:00,135 - vorta.borg.borg_job - INFO - Creating archive at "[...the path I removed from this issue]"
m3nu commented 9 months ago

That's odd, but I don't work enough with Linux desktops to be of help here. If it's not a packaging issue, we can definitely include the fix here in the project.

MartinX3 commented 9 months ago

Resizing the window fixed it for me, but I'm using XFCE.

sten0 commented 9 months ago

@topas-rec

ArchLinux kernel 6.7.0-arch3-1, GNOME Shell 45.3

If I remember correctly this version of GNOME Shell assumes "client side decorations", and this is where the border and shadow are drawn. Would you please check if other PyQt applications like Calibre or Transmission GUI (Qt variant, not the GTK+ one) have borders and shadows?

topas-rec commented 9 months ago

Thanks for helping me.

Resizing doesn't help here.

Transmission looks good. edit: I use transmission-gtk image

The only issue similarity between them is that they both don't have an icon in the panel or overview. image

topas-rec commented 9 months ago

I have QtQr installed which looks good. image

That should be sufficient for a QT application test, right?

real-yfprojects commented 9 months ago

That should be sufficient for a QT application test, right?

In principle yes. Where did you install QtQr from? I cannot find their repo.

I doubt there is much Vorta can do about this issue. Maybe there is a flag needed for niche setups. I found these articles online:

https://fostips.com/no-window-border-qt-apps-gnome/ https://ubuntuhandbook.org/index.php/2023/10/window-border-shadow-qt-apps-ubuntu/

topas-rec commented 9 months ago

The installation is from the arch repository: https://archlinux.org/packages/extra/any/qtqr/

PKGBUILD: https://gitlab.archlinux.org/archlinux/packaging/packages/qtqr/-/blob/main/PKGBUILD?ref_type=heads

topas-rec commented 8 months ago

I currently have version 0.9.1 installed (and updated my system of course) and the issue currently is gone.

image

vorta has a window border like all other windows.

topas-rec commented 5 months ago

This issue is back, sadly.

I found something that might be related in the command output of the terminal when starting vorta: qt.core.qobject.connect: QObject::connect: No such signal QPlatformNativeInterface::systemTrayWindowChanged(QScreen*)

Full command ``` [tobiasb@tobias-pc ~]$ vorta 2024-05-27 21:54:45,150 - vorta.i18n - DEBUG - Loading translation failed for ['en-Latn-GB', 'en-GB']. qt.core.qobject.connect: QObject::connect: No such signal QPlatformNativeInterface::systemTrayWindowChanged(QScreen*) 2024-05-27 21:54:45,184 - vorta.views.source_tab - DEBUG - Added item number 0 from 1 2024-05-27 21:54:45,184 - vorta.views.source_tab - DEBUG - Added item number 1 from 2 2024-05-27 21:54:45,185 - vorta.views.source_tab - DEBUG - Added item number 2 from 3 2024-05-27 21:54:45,256 - root - INFO - Using NetworkManagerMonitor NetworkStatusMonitor implementation. 2024-05-27 21:54:45,331 - vorta.borg.jobs_manager - DEBUG - Add job for site default 2024-05-27 21:54:45,332 - vorta.borg.jobs_manager - DEBUG - Start job on site: default 2024-05-27 21:54:45,335 - vorta.borg.borg_job - INFO - Running command /usr/bin/borg --version 2024-05-27 21:54:45,536 - vorta.borg.jobs_manager - DEBUG - Finish job for site: default 2024-05-27 21:54:45,536 - vorta.borg.jobs_manager - DEBUG - No more jobs for site: default 2024-05-27 21:54:45,536 - vorta.scheduler - DEBUG - Refreshing all scheduler timers 2024-05-27 21:54:45,537 - vorta.scheduler - DEBUG - Scheduler for profile 1 is disabled. 2024-05-27 21:54:45,539 - vorta.scheduler - DEBUG - Scheduler for profile 2 is disabled. 2024-05-27 21:56:36,341 - vorta.borg.borg_job - DEBUG - Cancel job on site default 2024-05-27 21:56:36,341 - vorta.borg.jobs_manager - INFO - Finished cancelling all jobs ```

I found these articles online:

https://fostips.com/no-window-border-qt-apps-gnome/ https://ubuntuhandbook.org/index.php/2023/10/window-border-shadow-qt-apps-ubuntu/

The second article mentions environmental variables. When I add QT_QPA_PLATFORM=xcb vorta gets the GNOME window borders and that looks good - native: image

The message in the terminal mentioned above is also gone.

Full command ``` [tobiasb@tobias-pc ~]$ QT_QPA_PLATFORM=xcb vorta 2024-05-27 22:14:51,993 - vorta.i18n - DEBUG - Loading translation failed for ['en-Latn-GB', 'en-GB']. 2024-05-27 22:14:52,027 - vorta.views.source_tab - DEBUG - Added item number 0 from 1 2024-05-27 22:14:52,028 - vorta.views.source_tab - DEBUG - Added item number 1 from 2 2024-05-27 22:14:52,028 - vorta.views.source_tab - DEBUG - Added item number 2 from 3 2024-05-27 22:14:52,104 - root - INFO - Using NetworkManagerMonitor NetworkStatusMonitor implementation. 2024-05-27 22:14:52,165 - vorta.borg.jobs_manager - DEBUG - Add job for site default 2024-05-27 22:14:52,165 - vorta.borg.jobs_manager - DEBUG - Start job on site: default 2024-05-27 22:14:52,169 - vorta.borg.borg_job - INFO - Running command /usr/bin/borg --version 2024-05-27 22:14:52,367 - vorta.borg.jobs_manager - DEBUG - Finish job for site: default 2024-05-27 22:14:52,367 - vorta.borg.jobs_manager - DEBUG - No more jobs for site: default 2024-05-27 22:14:52,368 - vorta.scheduler - DEBUG - Refreshing all scheduler timers 2024-05-27 22:14:52,369 - vorta.scheduler - DEBUG - Scheduler for profile 1 is disabled. 2024-05-27 22:14:52,370 - vorta.scheduler - DEBUG - Scheduler for profile 2 is disabled. 2024-05-27 22:15:21,270 - vorta.borg.borg_job - DEBUG - Cancel job on site default 2024-05-27 22:15:21,270 - vorta.borg.jobs_manager - INFO - Finished cancelling all jobs ```

When I add QT_QPA_PLATFORM=wayland nothing changes - the issue persists.

The message mentioned above is also present.

Full command ``` [tobiasb@tobias-pc ~]$ QT_QPA_PLATFORM=wayland vorta 2024-05-27 21:58:25,526 - vorta.i18n - DEBUG - Loading translation failed for ['en-Latn-GB', 'en-GB']. qt.core.qobject.connect: QObject::connect: No such signal QPlatformNativeInterface::systemTrayWindowChanged(QScreen*) 2024-05-27 21:58:25,568 - vorta.views.source_tab - DEBUG - Added item number 0 from 1 2024-05-27 21:58:25,568 - vorta.views.source_tab - DEBUG - Added item number 1 from 2 2024-05-27 21:58:25,568 - vorta.views.source_tab - DEBUG - Added item number 2 from 3 2024-05-27 21:58:25,641 - root - INFO - Using NetworkManagerMonitor NetworkStatusMonitor implementation. 2024-05-27 21:58:25,708 - vorta.borg.jobs_manager - DEBUG - Add job for site default 2024-05-27 21:58:25,708 - vorta.borg.jobs_manager - DEBUG - Start job on site: default 2024-05-27 21:58:25,712 - vorta.borg.borg_job - INFO - Running command /usr/bin/borg --version 2024-05-27 21:58:25,911 - vorta.borg.jobs_manager - DEBUG - Finish job for site: default 2024-05-27 21:58:25,911 - vorta.borg.jobs_manager - DEBUG - No more jobs for site: default 2024-05-27 21:58:25,911 - vorta.scheduler - DEBUG - Refreshing all scheduler timers 2024-05-27 21:58:25,913 - vorta.scheduler - DEBUG - Scheduler for profile 1 is disabled. 2024-05-27 21:58:25,914 - vorta.scheduler - DEBUG - Scheduler for profile 2 is disabled. 2024-05-27 21:58:31,908 - vorta.borg.borg_job - DEBUG - Cancel job on site default 2024-05-27 21:58:31,908 - vorta.borg.jobs_manager - INFO - Finished cancelling all jobs ```
github-actions[bot] commented 2 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] commented 2 months ago

This issue was closed because it has been stalled for 7 days with no activity.

topas-rec commented 2 months ago

This issue still persists.

m3nu commented 2 months ago

I don't know how to address this, but if someone can do a PR and confirm it works, we'll merge it.