search

borgbase / vorta

Desktop Backup Client for Borg Backup
https://vorta.borgbase.com
GNU General Public License v3.0
1.93k stars 127 forks source link

A file dialog for selecting `pre-backup` and `post-backup` scripts in the Schedule/Shell Commands section #1945

Open SAMAD101 opened 4 months ago

SAMAD101 commented 4 months ago

The problem

It's not very comfortable in the case of longer scripts.

Requested Solution

Addition of file selection dialog for selecting the shell script which could copy its contents to the pre_backup_cmd or post_backup_cmd Screenshot_20240225_155022-1 Like a button to do it at around the circled area.

Alternatives

One can write the shell in a text editor and copy the whole file in there as a work around. But having a little file selector to do that sounds like a basic feature to have.

shivansh02 commented 4 months ago

Hi @SAMAD101 is this how you want the UI to look? Screenshot from 2024-02-28 14-14-00

SAMAD101 commented 4 months ago

@shivansh02 That looks decent, but ig a file/folder icon would suit better

m3nu commented 4 months ago

Or a button to open a larger editing window/modal with mono-width font?

SAMAD101 commented 4 months ago

Or a button to open a larger editing window/modal with mono-width font?

Sounds like an idea. But maybe it's an overkill for a simple feature (maybe I'm just imaging it).

I've made a PR, please check and see how that look.

github-actions[bot] commented 1 month ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.