Vorta displays the same name for all archives

[romlok]

Description

1. Go to "Archives" tab
2. Double-click an archive name
3. Press escape to abort editing the name
4. Click "extract" for an archive
5. :warning: All archives get given name of the double-clicked archive :warning:
6. The extract window appears

This also affects any archives created after this point too.

The archives aren't actually renamed, as quitting and restarting Vorta will have them return to their correct names. However, in the bugged state, the incorrect names will be used for other functions, such as diffing (which results in an exception because it expects the names to be unique keys).

Reproduction

• [X] I tried to reproduce the issue.
• [X] I was able to reproduce the issue.

OS

Debian Testing, KDE Plasma 5.27.11

Version of Vorta

0.9.1

What did you install Vorta with?

Distribution package

Version of Borg

1.4.0

Logs

2024-07-19 15:14:28,563 - vorta.keyring.abc - DEBUG - No module named 'objc'
2024-07-19 15:14:28,585 - vorta.keyring.abc - DEBUG - Using VortaKWallet5Keyring
2024-07-19 15:14:28,585 - vorta.borg.borg_job - DEBUG - Using VortaKWallet5Keyring keyring to store passwords.
2024-07-19 15:14:28,586 - vorta.keyring.kwallet - DEBUG - Retrieved password for repo ssh://blah@blah.repo.borgbase.com/./repo
2024-07-19 15:14:28,594 - vorta.borg.jobs_manager - DEBUG - Add job for site 2
2024-07-19 15:14:28,594 - vorta.borg.jobs_manager - DEBUG - Start job on site: 2
2024-07-19 15:14:28,603 - vorta.borg.borg_job - INFO - Running command /usr/bin/borg list --info --log-json --json-lines --format {mode}{user}{group}{size}{isomtime}{path}{source}{health}{NL} ssh://blah@blah.repo.borgbase.com/./repo::elyvilon-2024-07-17-182346
2024-07-19 15:14:30,105 - vorta.borg.jobs_manager - DEBUG - Finish job for site: 2
2024-07-19 15:14:30,105 - vorta.borg.jobs_manager - DEBUG - No more jobs for site: 2
2024-07-19 15:14:30,106 - vorta.scheduler - INFO - Setting timer for profile 1
2024-07-19 15:14:30,106 - vorta.scheduler - DEBUG - Scheduling next run for 2024-07-19 21:39:55.077533

[m3nu]

Nice find! Can you check this out, @shivansh02 ? Has a good description and would be pretty serious.

[shivansh02]

@m3nu The only solution I could come up with is setting renamed_archive_original_name = None before all the actions(recalc, extract, etc) using a decorator/helper function. I'm not sure if its the best solution though.

[m3nu]

Thanks for looking into it. That doesn't sound too good. Without knowing the details, could we catch the escape-event somewhere to deal with it properly? They should be one or more Qt events for it.