validation and compaction interval not changeable

borgbase / vorta

Desktop Backup Client for Borg Backup

https://vorta.borgbase.com

GNU General Public License v3.0

2k stars 133 forks source link

validation and compaction interval not changeable #2101

Open ThomasWaldmann opened 3 days ago

ThomasWaldmann commented 3 days ago

Description

See picture:

the compaction interval is disabled, so one can not change the value of it. i did not touch anything there, so this is a bug: it should be changeable.
the validation interval is enabled, so one can change the value of it. this is because i toggled the checkmark to off and to on again to get it into that state. this is a workaround for this bug.

Reproduction

[X] I tried to reproduce the issue.
[X] I was able to reproduce the issue.

OS

macOS 15

Version of Vorta

0.10.0 beta1

What did you install Vorta with?

Binary

Version of Borg

1.4.0

Logs

No response

m3nu commented 3 days ago

Can't reproduce this one either. 😬 Must be some specific condition.

ThomasWaldmann commented 3 days ago

I suspect this is because of a yet missing setting in my config. Once you touch/toggle it, the settings get written/initialized and from that on it is ok.

But it should be also ok when upgrading from an older vorta that did not have that setting yet.

m3nu commented 3 days ago

OK. Will check if there is any dependency on default settings.

ThomasWaldmann commented 3 days ago

Interesting. I made a backup, maybe also restarted vorta and now I get this again:

So the value selection is disabled, again. So guess that does not confirm my theory from previous post.

ThomasWaldmann commented 3 days ago

I can also reproduce this for vorta built from master branch: after starting vorta, the values are not enabled.

ThomasWaldmann commented 3 days ago

I think in SchedulePage, populate_from_profile needs to be called after the connections are set up.

m3nu commented 3 days ago

That's possible. Our GSoC student did some refactoring in this tab to split it into multiple components. Wouldn't be surprised to see a small bug here and there.

m3nu commented 1 day ago

Added a PR for this. Does just moving the populate_from_profile() fix it?