search

borgbase / vorta

Desktop Backup Client for Borg Backup
https://vorta.borgbase.com
GNU General Public License v3.0
1.98k stars 130 forks source link

Icon vorta #229

Closed Hofer-Julian closed 5 years ago

Hofer-Julian commented 5 years ago

Currently vorta has no icon (see fourth entry in the image). Is it possible to change that? grafik

m3nu commented 5 years ago

You're the Linux expert. I discussed this with Thomas some time ago and he mentioned that usually distributions take care of this stuff while packaging an app. See Archlinux for an example where they added the icon. I'm not sure it can be added on the Python side.

Hofer-Julian commented 5 years ago

Interesting. I kind of expected that it would be possible on the Python side for macOS and Linux. I will look into the AUR as you suggest.

Do you see an icon on macOS?

m3nu commented 5 years ago

For macOS I package the app with Pyinstaller and the icon is added there. But this is unrelated to Linux.

Hofer-Julian commented 5 years ago

@m3nu so the fat binary on linux has an icon as well? I can't test it, because it doesn't work on Fedora 29

m3nu commented 5 years ago

The way a fat bin is built for Linux is different from macOS. It won't show up there, but needs to use the desktop's or distribution's mechanism. That's why we decided to leave it to the packagers.

Hofer-Julian commented 5 years ago

Okay!

m3nu commented 5 years ago

It's still a valid issue, but probably a duplicate of either #209 or at least related.

m3nu commented 5 years ago

Let's keep it closed for now. Maybe someone finds out how icons are managed on Linux desktops.

brokenpip3 commented 5 years ago

Hi, i created the icon and .desktop file for the aur packages, you can find here:

https://gist.github.com/brokenpip3/0ea26e0f5fc7bd5f061df1efe1594291

The icon was grabbed from the mac one converted in png format.

But this is package maintainer issue, imho.

which distribution you use @Hofer-Julian ?

Hofer-Julian commented 5 years ago

I use Fedora 29 and installed vorta per pip. I never installed a GUI app per pip before, that's why I didn't know that it's normal that no icon is displayed.

MatejKovacic commented 5 years ago

.desktop files in Ubuntu are stored in /usr/share/applications directory.

cat /usr/share/applications/vorta.desktop 

[Desktop Entry]
Encoding=UTF-8
Name=vorta
Type=Application
Comment=BorgBackup GUI for macOS and Linux
Exec=vorta
Icon=vorta32.png
Terminal=false
Categories=Application;Utility;Qt;

However, I am not sure where to put the icon file. Anyhow, you can always use absolute path to file...

Another option is to copy .desktop file to ~/.local/share/applications and use an absolute path to your icon instead of just the file name:

[Desktop Entry]
Encoding=UTF-8
Name=vorta
Type=Application
Comment=BorgBackup GUI for macOS and Linux
Exec=vorta
Icon=~/.local/share/applications/vorta32.png
Terminal=false
Categories=Application;Utility;Qt;