borgbase / vorta

Desktop Backup Client for Borg Backup
https://vorta.borgbase.com
GNU General Public License v3.0
2k stars 132 forks source link

Exclude patterns GUI improvements #907

Closed m3nu closed 6 days ago

m3nu commented 3 years ago

Just noticed that Nextcloud (desktop client) comes with a nice list of default exclusions. Maybe something for Vorta to assimilate.

I agree that one simple kind of patterns would be enough.

Originally posted by @m3nu in https://github.com/borgbase/vorta/discussions/838#discussioncomment-369487

diivi commented 1 year ago

Oh yeah, the implementation itself will be a json, I just meant to list what's needed 😅

sammcj commented 1 year ago

If it helps these are the excludes I use on macOS:

**/.minikube/
**/.npm/
**/.platformio
**/.rbenv
**/.rvm
**/.timemachine/
**/.Trash
**/.wine
**/*.DS_Store
**/*.git
**/*.temp
**/*.tmp
**/*diffusionbee/
**/*docker-desktop/
**/*lima/
**/*nstall*.dmg
**/*universal*.dmg
**/*x64*.dmg
**/docker-volumes/
**/iTunes/iTunes Media/podcasts/
**/iTunes/iTunes Music/
**/miniconda3/
**/node_modules/
**/nomic.ai/
**/temp/
**/tmp/
**/Virtual Machines/
**/Xcode.app/
/Applications
/Users/**/_NoSync_NoBackup/
/Users/*/.asdf
/Users/*/.cache
/Users/*/.cargo
/Users/*/.colima
/Users/*/.docker
/Users/*/.platformio
/Users/*/Applications
/Users/*/container_mount/
/Users/*/Documents/Adobe/
/Users/*/git/
/Users/*/go/
/Users/*/Library/Application Support/Autodesk/
/Users/*/Library/Application Support/Caches/
/Users/*/Library/Application Support/Code/Cache*/
/Users/*/Library/Application Support/coreMLCache/
/Users/*/Library/Application Support/Firefox/Profiles/*/storage/temporary/
/Users/*/Library/Application Support/Firefox/Profiles/*/storage/to-be-removed/
/Users/*/Library/Application Support/Firefox/Profiles/storage/default/
/Users/*/Library/Application Support/fnm/
/Users/*/Library/Application Support/Google/Chrome/*Cache*/
/Users/*/Library/Application Support/Google/Chrome/File System/
/Users/*/Library/Application Support/Google/Chrome/IndexDB/
/Users/*/Library/Application Support/Google/Chrome/Safe Browsing/
/Users/*/Library/Application Support/Google/Chrome/Service Worker/
/Users/*/Library/Arduino15/
/Users/*/Library/Caches/
/Users/*/Library/Containers/com.apple.AMPArtworkAgent/
/Users/*/Library/Containers/com.bitdefender.*/
/Users/*/Library/Containers/com.microsoft.*/
/Users/*/Library/Containers/F807763E-5B70-49A2-B0B0-E13291698A23/
/Users/*/Library/Developer/
/Users/*/Library/Metadata/
/Users/*/Library/Saved Application State/
/Users/*/Music/
/Volumes/*timemachine*/
/Volumes/*TimeMachine*/
jakesmolka commented 1 year ago

Sounds awesome @diivi 👍 Looking forward using this feature. Please also check https://github.com/SterlingHooten/borg-backup-exclusions-macos not just for the lists, but also for the knowledge – if that helps.

m3nu commented 1 year ago

Love all the input, @jakesmolka and @sammcj . Will be great to bundle this knowledge with Vorta. We just need to group it all a bit.

@diivi , you see your feature is already very popular. I suggest to add the most obvious input from here to the first version, but also prioritize getting something usable out of the door and then add more exclusion rules over time.

goebbe commented 1 month ago

Thank you for the flexible interface for "exclude"!

There is one point that is quite confusing in borg - and since Vorta is referring to the borg documentation, this applies to Vorta too.

In borg there are two distinct sets of options which can be used for excludes: --exclude and --exclude-from AND --pattern or --patterns-from

Only the second set of options uses the term "pattern" in its name. To cite the borg documentation:

A more general and easier to use way to define filename matching patterns exists with the --pattern and --patterns-from options. Using these, one may specify the backup roots, default pattern styles and patterns for inclusion and exclusion.

If I understand correctly, currently, Vorta only supports --exclude. This should be stressed in the user interface (which links to the borg documentation) to reduce the confusion.

m3nu commented 6 days ago

Closing this, since the feature is done. Move the last comment by @goebbe to a new issue.

notDavid commented 6 days ago

So if anyone has a grouped list (or even one set of patterns) [...]

Hi there,

i'm only seeing this now while the issue was just closed, but perhaps this exclusion list for macOS is still useful...: https://github.com/SterlingHooten/borg-backup-exclusions-macos

m3nu commented 6 days ago

Could be. Made a new issue for this. Thanks for the link!