borglab / GTDynamics

Full kinodynamics constraints for arbitrary robot configurations with factor graphs.
BSD 2-Clause "Simplified" License
39 stars 10 forks source link

Remove kinpy as a dependency #245

Closed varunagrawal closed 3 years ago

varunagrawal commented 3 years ago

Following from #242.

varunagrawal commented 3 years ago

Yes but we don't use it anywhere else. Having users import a package (e.g. on a robot) that doesn't provide core functionality seems wasteful.

Plus, I had kinpy print out the FK transforms and added them as regression values so that the test still does the same job. :)

dellaert commented 3 years ago

Note, some checks seem to be failing...