borglab / GTDynamics

Full kinodynamics constraints for arbitrary robot configurations with factor graphs.
BSD 2-Clause "Simplified" License
39 stars 10 forks source link

Memory warning in PneumaticActuatorFactors #265

Closed dellaert closed 2 years ago

dellaert commented 3 years ago
/home/runner/work/GTDynamics/GTDynamics/gtdynamics/jumpingrobot/factors/PneumaticActuatorFactors.h: In member function ‘virtual gtsam::Vector gtdynamics::SmoothActuatorFactor::evaluateError(const double&, const double&, const double&, boost::optional<Eigen::Matrix<double, -1, -1>&>, boost::optional<Eigen::Matrix<double, -1, -1>&>, boost::optional<Eigen::Matrix<double, -1, -1>&>) const’:
/home/runner/work/GTDynamics/GTDynamics/gtdynamics/jumpingrobot/factors/PneumaticActuatorFactors.h:282:46: warning: ‘j_f0_p’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  282 |       if (H_p) H_p->setConstant(1, 1, j_f0_p - j_k_p * delta_x);
      |                                       ~~~~~~~^~~~~~~~~~~~~~~~~
/home/runner/work/GTDynamics/GTDynamics/gtdynamics/jumpingrobot/factors/PneumaticActuatorFactors.h:282:46: warning: ‘j_k_p’ may be used uninitialized in this function [-Wmaybe-uninitialized]
varunagrawal commented 3 years ago

Umm why is the invalid label set to this? Invalid would mean that the bug submitted is not due to our code and is usually due to something on the reporter's system (at least that is the definition we use for GTSAM and other repos).