borglab / GTDynamics

Full kinodynamics constraints for arbitrary robot configurations with factor graphs.
BSD 2-Clause "Simplified" License
39 stars 10 forks source link

add equality constraint representation #287

Closed yetongumich closed 2 years ago

yetongumich commented 2 years ago

Add EqualityConstriant in 3 ways:

This is the first PR. The second PR will contain the penalty method optimizer and the augmented Lagrangian optimizer.

yetongumich commented 2 years ago

Looks really good. I think using my comments it can be even tighter. Consider removing the example.H file and just putting examples inside the test file.

I will also use the example in some future test files, e.g. testAugmentedLagrangianOptimizer.cpp

yetongumich commented 2 years ago

There are a few comments that I cannot resolve, and they need further discussion. I left my reply comments for each of them.

yetongumich commented 2 years ago

Please remove EqualityConstraints. It adds useless code. Unless you can clearly explain its value a normal vector should do.

Removed.

yetongumich commented 2 years ago

Merging, with 2 improvements in the future: