borglab / GTDynamics

Full kinodynamics constraints for arbitrary robot configurations with factor graphs.
BSD 2-Clause "Simplified" License
39 stars 10 forks source link

Kill JointTyped #291

Closed gchenfc closed 2 years ago

gchenfc commented 2 years ago

This abandons future plans for Ball/Spherical/U-joints. Reasons:

Frank’s response (after much deliberation):

Can re-target to master if #290 is rejected. I forget why I based this branch on the other one - probably just forgot to checkout back to master before starting this work.

gchenfc commented 2 years ago

@dellaert I remember you said to wait on this until another PR landed (#278 ?) but not sure what the status on that is

dellaert commented 2 years ago

I think we can merge, @danbarla will have to merge in master then...

gchenfc commented 2 years ago

@dellaert Sorry I totally forgot to re-target to master, and then I royally messed up and accidentally force-pushed. But after messing up once, I learned so next time I'll know how to do it right.

But everything should be addressed now!