search

borglab / GTDynamics

Full kinodynamics constraints for arbitrary robot configurations with factor graphs.
BSD 2-Clause "Simplified" License
39 stars 10 forks source link

CI fixes #298

Closed varunagrawal closed 2 years ago

varunagrawal commented 2 years ago

Fixes to the CI

varunagrawal commented 2 years ago

Turns out the issue was not clang-9 but a recent TBB update we merged in GTSAM. https://github.com/borglab/gtsam/pull/901

varunagrawal commented 2 years ago

@dellaert @danbarla the CI runs correctly and all checks pass. Can we merge this?

acxz commented 2 years ago

Turns out the issue was not clang-9 but a recent TBB update we merged in GTSAM.

Hello @varunagrawal not sure where to comment this, but it seems like this is the best place short of making a new issue. I tried compiling GTDynamics with GTSAM with TBB and without TBB and both compiled fine on my machine. The runtime errors were also the same for me. If there is anything specific related to the gtsam tbb commit or if you have an error log, I can try to look into if you make an issue in this repo and just ping me on it.

varunagrawal commented 2 years ago

We undid the TBB change so you may want to apply it again and try. We get intermittent test failures so if you can track down the issue that would be awesome!

(I think it's a race condition but haven't had the time to look into it deeply)

acxz commented 2 years ago

Oh yeah forgot it wasn't in the latest 4.1.1 release.