search

borglab / GTDynamics

Full kinodynamics constraints for arbitrary robot configurations with factor graphs.
BSD 2-Clause "Simplified" License
39 stars 10 forks source link

Split `DynamicsGraph` into separate files #3

Open gchenfc opened 4 years ago

gchenfc commented 4 years ago

This issue was imported from github.gatech.edu. The original issue was opened by @aescontrela3 on 2020-02-18T06:02:54Z and assigned to @yzhang3333 @aescontrela3 @smccormick32

Currently, DynamicsGraph is bloated and complex, containing code for trajectory optimization, graph visualization, single timestep dynamics graphs, etc. To decrease code complexity this class should be split up into multiple classes and perhaps some utility files.

I agree. @yzhang3333 have discussed splitting DynamicsGraph into multiple separate files (e.g. trajectory stuff, dynamics graph stuff, etc.), but those changes are out of the scope of this PR. I'll make an issue regarding this.

_Originally posted by @aescontrela3 in https://github.gatech.edu/borglab/GTDynamics/pull/6/review_comment/create_

varunagrawal commented 2 years ago

@yetongumich can you tackle this soon? I need to use the dynamics graph for something I'm trying and would like to avoid merge conflicts.

yetongumich commented 2 years ago

@yetongumich can you tackle this soon? I need to use the dynamics graph for something I'm trying and would like to avoid merge conflicts.

Yes, I'll get it done before next Tuesday.

varunagrawal commented 1 year ago

Any updates on this?