borglab / GTDynamics

Full kinodynamics constraints for arbitrary robot configurations with factor graphs.
BSD 2-Clause "Simplified" License
39 stars 10 forks source link

Jumping Robot Python Tests #314

Closed varunagrawal closed 2 years ago

varunagrawal commented 2 years ago

Adds tests for the Jumping Robot to the CI.

Currently 2 tests fail. @yetongumich can you please also look into this since I will not get to it until the 11/30.

dellaert commented 2 years ago

Why is this on your A->B right now?

varunagrawal commented 2 years ago

It isn't. It was some pending changes I wanted to get out of the way before I lost them to the void.

dellaert commented 2 years ago

CI fails

varunagrawal commented 2 years ago

Yup, my PR comment explicitly asks Yetong to look into this since he's the owner of this codebase.

varunagrawal commented 2 years ago

The issue is that the Python tests for the Jumping Robot were never added to the CI until now, that's why you're seeing the tests fail in this PR.

yetongumich commented 2 years ago

Sorry I just noticed this PR review. It seems the two libraries matplotlib and yaml may not be installed in the travis Python version. I'll make a commit into this branch to handle that.

yetongumich commented 2 years ago

The previous CI fail due to the pyyaml package dependency, and the update on the Link constructor. After revising the issues, all checks have passed.