search

borglab / GTDynamics

Full kinodynamics constraints for arbitrary robot configurations with factor graphs.
BSD 2-Clause "Simplified" License
39 stars 10 forks source link

Python wrapper update #318

Closed gchenfc closed 11 months ago

gchenfc commented 2 years ago

I found this cleaning up old local stashes - I think it was needed by Natalie at one point but then wasn't anymore; in any case, it's probably useful to have wrapped still.

@nrakoski3 , if you have time could you make a short unit test for IK drawing from some of your code, as well as tests for any other classes you need from gtdynamics? I might recommend putting it in test_forward_kinematics.py then renaming the file to just test_kinematics.py

varunagrawal commented 2 years ago

The PointGoalFactor might be removed soon. Otherwise this PR looks great. Can you add some simple unit tests please?

dellaert commented 2 years ago

Jerry please add quick unit test before merging. Also merge in master so CI checks that

gchenfc commented 2 years ago

will do (after fixing cablerobot segfault)

varunagrawal commented 2 years ago

Ping @gchenfc

varunagrawal commented 11 months ago

I added the unit tests, merging.