search

borglab / GTDynamics

Full kinodynamics constraints for arbitrary robot configurations with factor graphs.
BSD 2-Clause "Simplified" License
39 stars 10 forks source link

include(GNUInstallDirs) #330

Closed yetongumich closed 2 years ago

yetongumich commented 2 years ago

I encountered the same issue as #324, and it turned out ${CMAKE_INSTALL_INCLUDEDIR} is empty during compilation.

By looking at CMake documentation, I discover that we forgot to include GNUInstallDirs. After adding the line include(GNUInstallDirs), everything works fine.

I'd also suggest to add make install into out github workflow so that we can check if installation is successful.

yetongumich commented 2 years ago

Adding make install seems reasonable to me as well

Sounds good! I'll make another PR to include "make install" in github workflow

varunagrawal commented 2 years ago

Just add the make install to this PR. It will be all housekeeping related.

yetongumich commented 2 years ago

Added "make install" check and merging