search

borglab / GTDynamics

Full kinodynamics constraints for arbitrary robot configurations with factor graphs.
BSD 2-Clause "Simplified" License
39 stars 10 forks source link

DynamicsGraph.h missing #include <boost/format.hpp> #336

Closed arutkowski closed 2 years ago

arutkowski commented 2 years ago

Trying to build GTDynamics, I got the following error:

In file included from /home/adam/GTDynamics/gtdynamics/dynamics/DynamicsGraph.cpp:34:
/home/adam/GTDynamics/gtdynamics/utils/JsonSaver.h: In static member function ‘static std::string gtdynamics::JsonSaver::GetNoiseModel(const shared_ptr&)’:
/home/adam/GTDynamics/gtdynamics/utils/JsonSaver.h:262:22: error: ‘format’ is not a member of ‘boost’; did you mean ‘boost::timer::format’?
  262 |         ss << boost::format("isotropic dim=%1% sigma=%2%") %
      |

Adding #include <boost/format.hpp> to DynamicsGraph.h seems to fix the issue.

dellaert commented 2 years ago

Ah, yes - I have removed that include from Matrix.h in gtsam. Sorry! Feel free to make a PR but that file should be in a cpp file where used if possible to avoid header bloat.

dellaert commented 2 years ago

I went ahead and created #337 but now get in trouble building python wrapper. Confirm this works for you?

varunagrawal commented 2 years ago

Can confirm #337 works. @dellaert can you try rebuilding the project from scratch?

dellaert commented 2 years ago

Removing build and starting from scratch worked. Probably because my build folder was rather old. I'll close this issue then.