search

borglab / GTDynamics

Full kinodynamics constraints for arbitrary robot configurations with factor graphs.
BSD 2-Clause "Simplified" License
39 stars 10 forks source link

Fix to get gtdynamics to compile #338

Closed varunagrawal closed 2 years ago

varunagrawal commented 2 years ago

Recent updates from GTSAM now require us to explicitly include boost/format.hpp.

varunagrawal commented 2 years ago

Also as an FYI, JsonSaver.h has a license referring to Holomatic. We should probably update it or remove it to avoid potential legal issues?

dellaert commented 2 years ago

Uhm, #337 ? Also, you should really carefully think about including things like boost::format in headers.

varunagrawal commented 2 years ago

Huh didn't see that, thank you! I figured that JsonSaver.h already had a boost import so adding another wouldn't be too bad?

dellaert commented 2 years ago

Headers should be as specific as possible, esp. boost headers, because they can substantially increase compile times.