borglab / SwiftFusion

Apache License 2.0
115 stars 13 forks source link

first draft of expectation maximization code. #265

Closed acoadmarmon closed 3 years ago

acoadmarmon commented 3 years ago

Still working on this expectation maximization code (this is a functional MVP), but wanted to create this PR so we can iteratively refine this approach @ProfFan .

ProfFan commented 3 years ago

@acoadmarmon Could you fix the CI error and merge? I can then fix the PPCA code.

acoadmarmon commented 3 years ago

Ya sure I'll let you know once I've fixed that test! Shouldn't take much time.

acoadmarmon commented 3 years ago

@ProfFan the latest commit should fix the CI error. Tests run locally.

acoadmarmon commented 3 years ago

@ProfFan I don't have write access so I can't merge this PR myself.

ProfFan commented 3 years ago

Oh, I'll merge, thanks :)