search

borglab / gtsam-project-python

Project template using GTSAM + python wrapping
BSD 2-Clause "Simplified" License
57 stars 15 forks source link

wrap folder reorganization #14

Closed gftabor closed 3 years ago

gftabor commented 3 years ago

The other warp python template uses git submodules to organize itself, instead of just the full wrap folder here. https://github.com/borglab/wrap-project-python

The tutorial here says its a gitsubtree? https://github.com/borglab/gtsam-project-python/blob/master/TUTORIAL.md

It seems if you are suggesting to use wrap as a library, both examples should support wrap being cloned + built separately rather than included in a project using it?

The documentation for wrap suggests to clone + build + install the wrap library, and then to come to this repo(for tutorial) which then will clone and build the wrap library again? https://github.com/borglab/wrap

gftabor commented 3 years ago

Ahhh more exploration of the various packages shows that my comments are likely already on the roadmap, here

https://github.com/borglab/wrap-project-python/pull/3

varunagrawal commented 3 years ago

Yeah this process has many moving parts. I am slowly updating all of them. :slightly_smiling_face:

gftabor commented 3 years ago

https://github.com/borglab/gtsam-project-python/pull/16